subnet/kube: Handle missed node deletions #982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the node controller misses the deletion of a node the DeltaFIFO will insert a tombstone object with the last known view of the object. This commit adds checking to the type assertion and extraction of the previous node object when possible. Signed-off-by: Richard Marshall <rgm@linux.com>
|
Sorry, I didn't spot this when I merged #1000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the node controller misses the deletion of a node the DeltaFIFO will insert a tombstone object (DeletedFinalStateUnknown) with the last known view of the object. The current code will panic due to a failed type assertion to v1.Node.
This PR includes a fix for this panic by checking the result of the type assertion and attempting to extract the last know state from the tombstone.
Todos
Release Note